This revision was automatically updated to reflect the committed changes.
Closed by commit rL296616: Introducing clang::tooling::AtomicChange for
refactoring tools. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D27054?vs=90018&id=90165#toc
Repository:
rL LLVM
https
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D27054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric updated this revision to Diff 90018.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Return const refs in getXXX.
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Refactoring/AtomicChan
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
alexshap wrote:
> ioeric wrote:
> > a
alexshap added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
ioeric wrote:
> alexshap wrote:
> >
ioeric updated this revision to Diff 90012.
ioeric marked an inline comment as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D27054
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Refactoring/AtomicChange.cpp
ioeric marked an inline comment as done.
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
-
alexshap added inline comments.
Comment at: lib/Tooling/Refactoring/AtomicChange.cpp:35
+RemovedHeaders(E.getRemovedHeaders()) {
+std::copy(E.getReplacements().begin(), E.getReplacements().end(),
+ std::back_inserter(Replaces));
if i am n
alexshap added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:59
+ /// \brief Returns the path of the file containing this atomic change.
+ std::string getFilePath() const { return FilePath; }
+
i assume i might be missing smth -
