EricWF added a comment.
@AntonBikineev Yeah, this should be abandoned. Sorry my mistake.
https://reviews.llvm.org/D26830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added inline comments.
Comment at:
test/std/strings/string.view/string.view.literals/literal2.pass.cpp:16
+
+int main()
+{
EricWF wrote:
> What's the point of this test that `literal.pass.cpp` doesn't cover?
Ping on this comment.
Commen
AntonBikineev added a comment.
In https://reviews.llvm.org/D26830#711870, @EricWF wrote:
> @AntonBikineev when will you be able to make he requested changes? I would
> like to land this ASAP.
Eric, have you looked at commit 7d32d2f5a1f39d4cae9469645faa74b647698001? This
functionality has alre
AntonBikineev added a comment.
In https://reviews.llvm.org/D26830#711870, @EricWF wrote:
> @AntonBikineev when will you be able to make he requested changes? I would
> like to land this ASAP.
Will do that today
https://reviews.llvm.org/D26830
__
EricWF added a comment.
@AntonBikineev when will you be able to make he requested changes? I would like
to land this ASAP.
https://reviews.llvm.org/D26830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
EricWF added a comment.
This LGTM. I'll approve once I see the inline comments addressed.
Comment at:
test/std/strings/string.view/string.view.literals/literal.pass.cpp:10
+//===--===//
+
+// UNSUPPORTED: c++9
EricWF added inline comments.
Comment at:
test/std/strings/string.view/string.view.literals/literal3.pass.cpp:16
+
+int main()
+{
You can move this test into `literal.pass.cpp` but putting it at another
function scope.
https://reviews.llvm.org/D26830
_
EricWF added a comment.
Alright. I committed the Clang changes. Just re-building now so I can test this.
Comment at: include/string_view:780
+} // namespace literals
+#endif
+
`// _LIBCPP_STD_VER > 14` comment please.
Comment at:
test/std/st
AntonBikineev added a comment.
In https://reviews.llvm.org/D26830#619340, @EricWF wrote:
> Please ping this once the Clang changes have been accepted. I'm just waiting
> on those to give this the final OK.
I don't have commit privileges to Clang either, so that patch is stuck. Could
you commi
EricWF added a comment.
Please ping this once the Clang changes have been accepted. I'm just waiting on
those to give this the final OK.
https://reviews.llvm.org/D26830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
AntonBikineev updated this revision to Diff 78532.
AntonBikineev marked an inline comment as done.
AntonBikineev added a comment.
Fixing typos...
https://reviews.llvm.org/D26830
Files:
include/string_view
test/std/strings/string.view/string.view.literals/literal.pass.cpp
test/std/strings/
AntonBikineev marked an inline comment as done.
AntonBikineev added inline comments.
Comment at: include/string_view:749
+inline namespace literals
+{
EricWF wrote:
> AntonBikineev wrote:
> > EricWF wrote:
> > > If this is new to C++17 then the new declarations
AntonBikineev updated this revision to Diff 78498.
https://reviews.llvm.org/D26830
Files:
include/string_view
test/std/strings/string.view/string.view.literals/literal.pass.cpp
test/std/strings/string.view/string.view.literals/literal1.fail.cpp
test/std/strings/string.view/string.view.lit
AntonBikineev updated this revision to Diff 78497.
https://reviews.llvm.org/D26830
Files:
include/string_view
test/std/strings/string.view/string.view.literals/literal.pass.cpp
test/std/strings/string.view/string.view.literals/literal1.fail.cpp
test/std/strings/string.view/string.view.lit
EricWF added inline comments.
Comment at: include/string_view:749
+inline namespace literals
+{
AntonBikineev wrote:
> EricWF wrote:
> > If this is new to C++17 then the new declarations should be guarded by `#if
> > _LIBCPP_VERSION > 14`.
> Eric, I was thinki
AntonBikineev updated this revision to Diff 78493.
AntonBikineev marked an inline comment as done.
https://reviews.llvm.org/D26830
Files:
include/string_view
test/std/strings/string.view/string.view.literals/literal.pass.cpp
test/std/strings/string.view/string.view.literals/literal1.fail.cp
AntonBikineev added inline comments.
Comment at: include/string_view:749
+inline namespace literals
+{
EricWF wrote:
> If this is new to C++17 then the new declarations should be guarded by `#if
> _LIBCPP_VERSION > 14`.
Eric, I was thinking about it, but the f
EricWF added a comment.
Which paper is this implementing?
Also please update the synopsis comment at the top of the header.
Comment at: include/string_view:749
+inline namespace literals
+{
If this is new to C++17 then the new declarations should be guarded
AntonBikineev created this revision.
AntonBikineev added reviewers: mclow.lists, rsmith, cfe-commits.
Herald added a reviewer: EricWF.
https://reviews.llvm.org/D26830
Files:
include/string_view
test/std/strings/string.view/string.view.literals/literal.pass.cpp
test/std/strings/string.view/s
19 matches
Mail list logo
