This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL287285: [CUDA] Driver changes to support CUDA compilation on
MacOS. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D26774?vs=78286&id=78
jlebar marked 2 inline comments as done.
jlebar added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+ // Intentionally omitted from the switch above: llvm::Triple::CUDA. CUDA
+ // compiles always need two toolchains, the CUDA toolchain and the host
+ //
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM, with couple of minor nits.
Comment at: clang/lib/Driver/Driver.cpp:3650-3654
+
+ // Intentionally omitted from the switch above: llvm::Triple::CUDA. CUDA
+ // compiles alw
jlebar added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:479
+// the device toolchain we create depends on both.
+ToolChain *&CudaTC = ToolChains[CudaTriple.str() + "/" + HostTriple.str()];
+if (!CudaTC) {
sfantao wrote:
> I am not sure I
sfantao added a comment.
Hi Justin,
Thanks for the patch.
Comment at: clang/lib/Driver/Driver.cpp:479
+// the device toolchain we create depends on both.
+ToolChain *&CudaTC = ToolChains[CudaTriple.str() + "/" + HostTriple.str()];
+if (!CudaTC) {
I
