[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2017-01-09 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists abandoned this revision. mclow.lists added a comment. This was resolved by https://reviews.llvm.org/D26829 https://reviews.llvm.org/D26667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); aaron.ballman wrote: > mclow.lists wrote: > > aaron.ballman wrote: > > > malcolm.parsons wrote: > > > >

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); mclow.lists wrote: > aaron.ballman wrote: > > malcolm.parsons wrote: > > > aaron.ballman wrote: >

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); aaron.ballman wrote: > malcolm.parsons wrote: > > aaron.ballman wrote: > > > mclow.lists wrote: > >

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); malcolm.parsons wrote: > aaron.ballman wrote: > > mclow.lists wrote: > > > malcolm.parsons wrote:

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); aaron.ballman wrote: > mclow.lists wrote: > > malcolm.parsons wrote: > > > This is in `NumericL

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); mclow.lists wrote: > malcolm.parsons wrote: > > This is in `NumericLiteralParser::isValidUDSuffix

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); malcolm.parsons wrote: > This is in `NumericLiteralParser::isValidUDSuffix()`. > > If a change is

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:768 .Cases("il", "i", "if", true) + .Case("sv", true) .Default(false); This is in `NumericLiteralParser::isValidUDSuffix()`. If a change is needed for `"sv"`, wouldn

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Testcases? https://reviews.llvm.org/D26667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26667: Teach clang that 'sv' is a fine literal suffix

2016-11-15 Thread Marshall Clow via cfe-commits
mclow.lists created this revision. mclow.lists added a reviewer: rsmith. mclow.lists added a subscriber: cfe-commits. Last week, WG21 approved a paper (http://wg21.link/P0403) for allowing literal suffixes for `string_view`. This means that should be able to write: constexpr std::string_view s