NoQ commandeered this revision.
NoQ added a reviewer: k-wisniewski.
NoQ added a comment.
Seems to become outdated with https://reviews.llvm.org/D27092.
https://reviews.llvm.org/D26589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:65
+
+ for (const auto *ParentLC = C.getStackFrame()->getParent();
+ ParentLC != nullptr; ParentLC = ParentLC->getParent()) {
Off-by-1: `C.getStackFrame()` is already t
NoQ added a comment.
Thank you for working on this! The overall approach is good. Because alpha
checkers are disabled by default, false positives can be addressed later in
subsequent commits.
Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:2
+// InfiniteRecursion
k-wisniewski added a comment.
@a.sidorin
Thank you for your review! I'll upload the new patch this evening that will
include fixes for the things you pointed out. Can I also add you as a reviewer?
Also: Can you have a look at my other patch that I have linked in the
description? Thanks in adva
a.sidorin added a comment.
Wow, thank you for such a contribution! Did you evaluate this checker on some
real code?
I have some minor inline comments below.
Comment at: lib/StaticAnalyzer/Checkers/CMakeLists.txt:41
IdenticalExprChecker.cpp
+RecursionChecker.cpp
k-wisniewski created this revision.
k-wisniewski added reviewers: zaks.anna, dcoughlin, dergachev.a.
k-wisniewski added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
This is the very first version of a checker that aims to find cases of infinite
recursion. It relies on Add Locati
