dougk added a comment.
I think it probably works to have the attribute appertain to any sanitizer. I
did not know that it did, so I conservatively assumed that it didn't. I'll go
ahead and make things consistent, and confirm that it dtrt.
https://reviews.llvm.org/D26454
__
aaron.ballman added a comment.
In https://reviews.llvm.org/D26454#609578, @dougk wrote:
> Suppression of sanitizing is necessary if the variable is magically a
> memory-mapped device I/O address.
> The linker can arrange for this to be the case using fancy scripts, or even
> just as simple as
dougk added a comment.
Suppression of sanitizing is necessary if the variable is magically a
memory-mapped device I/O address.
The linker can arrange for this to be the case using fancy scripts, or even
just as simple as a section attribute that requires that you take up exactly a
certain numbe
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5348
S.Diag(LiteralLoc, diag::warn_unknown_sanitizer_ignored) <<
SanitizerName;
-else if (isGlobalVar(D) && SanitizerName != "address")
+else if (isGlobalVar(D) && SanitizerName != "address
dougk updated this revision to Diff 77815.
dougk marked an inline comment as done.
dougk added a comment.
add a sentence about the change in AddressSanitizer.rst
https://reviews.llvm.org/D26454
Files:
docs/AddressSanitizer.rst
lib/CodeGen/SanitizerMetadata.cpp
lib/Sema/SemaDeclAttr.cpp
kcc added a comment.
Does this change deserve a documentation update?
https://reviews.llvm.org/D26454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dougk updated this revision to Diff 77658.
dougk marked 2 inline comments as done.
dougk added a comment.
changes per Aaron Ballman
https://reviews.llvm.org/D26454
Files:
lib/CodeGen/SanitizerMetadata.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/asan-globals.cpp
test/SemaCXX/attr-no-sanit
aaron.ballman added inline comments.
Comment at: lib/CodeGen/SanitizerMetadata.cpp:68
+ bool IsBlacklisted = false;
+ for (auto Attr : D.specific_attrs())
+if (Attr->getMask() & SanitizerKind::Address)
Should use `const auto *` (feel free to change the othe
dougk added a comment.
Also note: In this change, the diagnostic messages are correct; it's the enum
name that's bad. The diagnostic message is wrong for the 'section' attribute,
which is fixed by https://reviews.llvm.org/D26459
https://reviews.llvm.org/D26454
__
dougk created this revision.
dougk added a reviewer: aaron.ballman.
dougk added a subscriber: cfe-commits.
This was already submitted as r284272.
Regarding the use of Attr as a local variable name, I would prefer to remain
consistent with the existing code in CodeGenFunction.cpp which was not to
10 matches
Mail list logo
