This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL286427: [clang-move] Support template class. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D26423?vs=77292&id=77447#toc
Repository:
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
+ else
hokein wrote:
> ioeric wrote:
> > `erase(FTD ? FTD : CMD)`
> We can
hokein marked 3 inline comments as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
+ else
ioeric wrote:
> `erase(FTD
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with a few nits.
Comment at: clang-move/ClangMove.cpp:417
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate())
+UnremovedDeclsInOldHeader.erase(FTD);
hokein updated this revision to Diff 77292.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments.
https://reviews.llvm.org/D26423
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/template_class_test.cpp
test/clang-move/Inputs/template_class_test.h
test/cla
ioeric added a comment.
Nice!
First round of comments.
Comment at: clang-move/ClangMove.cpp:414
RemovedDecls.push_back(MovedDecls.back());
+ if (const auto *FTD = CMD->getDescribedFunctionTemplate()) {
+UnremovedDeclsInOldHeader.erase(FTD);
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D26423
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/template_class_test.cpp
test/clang-move/Inputs/template_class_test.h
test/clang-move/move-template-
