This revision was automatically updated to reflect the committed changes.
Closed by commit rL286096: Deduplicate replacements by FileEntry instead of
file names. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26288?vs=77008&id=77009#toc
Repository:
rL LLVM
https://
ioeric updated this revision to Diff 77008.
ioeric added a comment.
- Merge with origin/master
https://reviews.llvm.org/D26288
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unitt
ioeric added a comment.
Since Manuel's comment has been addressed, I'd like to land this if there is no
objection.
https://reviews.llvm.org/D26288
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
ioeric updated this revision to Diff 76975.
ioeric added a comment.
- addressed comments.
https://reviews.llvm.org/D26288
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/
klimek added a comment.
Ok, makes sense. Can you add a comment to the function that explains what
happens with replacements for files that do not exist (we ignore them, unless
I'm mistaken). Otherwise LG.
https://reviews.llvm.org/D26288
___
cfe-co
ioeric added a comment.
In https://reviews.llvm.org/D26288#587513, @klimek wrote:
> In https://reviews.llvm.org/D26288#586932, @ioeric wrote:
>
> > - Addressed comments: handle non-existing files.
>
>
> We're not really handling them now though? We're just printing an error?
>
> My point is that
klimek added a comment.
In https://reviews.llvm.org/D26288#586932, @ioeric wrote:
> - Addressed comments: handle non-existing files.
We're not really handling them now though? We're just printing an error?
My point is that we might run the replacement generation on a distributed
system, and t
ioeric added a comment.
In https://reviews.llvm.org/D26288#586902, @klimek wrote:
> If the files do not exist, how does this work? Won't that potentially give
> different results if the files exist locally vs if they don't?
This would be problematic. Thanks for the catch!
https://reviews.llv
ioeric updated this revision to Diff 76894.
ioeric added a comment.
- Addressed comments: handle non-existing files.
https://reviews.llvm.org/D26288
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
unittests/Tooling/Refactoring
klimek added a comment.
If the files do not exist, how does this work? Won't that potentially give
different results if the files exist locally vs if they don't?
https://reviews.llvm.org/D26288
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:578
+ continue;
+ProcessedFileEntries.insert(FE);
+Result[Entry.first] = std::move(Entry.second);
alexshap wrote:
> (saves 2 lines of code) (although not particularly importan
ioeric updated this revision to Diff 76888.
ioeric added a comment.
- Kill a few lines.
https://reviews.llvm.org/D26288
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/To
alexshap added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:578
+ continue;
+ProcessedFileEntries.insert(FE);
+Result[Entry.first] = std::move(Entry.second);
(saves 2 lines of code) (although not particularly important)
if (Proces
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The current version does not deduplicate equivalent file paths correctly.
For example, a relative path and an absolute path are considered inequivalent.
Compar
14 matches
Mail list logo
