[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

2016-10-31 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 76433. malcolm.parsons added a comment. Sort headers and CMakeLists.txt. https://reviews.llvm.org/D26138 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEqualsDeleteCheck.cpp cl

[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

2016-10-31 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 76431. malcolm.parsons added a comment. Rename to modernize-use-equals-delete. Add comment. https://reviews.llvm.org/D26138 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEqualsD

[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

2016-10-31 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D26138#583561, @alexfh wrote: > "Use delete" makes me think of the `delete` operator. I'd suggest one of > these names: I chose modernize-use-delete as there's already modernize-use-default. "Use default" makes me think of the `defau

[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

2016-10-31 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. "Use delete" makes me think of the `delete` operator. I'd suggest one of these names: - modernize-use-equals-delete - modernize-use-deleted-special-members - modernize-delete-special-members (feel free to suggest a better alternative). Comment at: cla

[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

2016-10-31 Thread Malcolm Parsons via cfe-commits
malcolm.parsons updated this revision to Diff 76410. malcolm.parsons added a comment. Add to release notes. https://reviews.llvm.org/D26138 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseDeleteCheck.cpp clang-tidy/moderniz

[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

2016-10-31 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). https://reviews.llvm.org/D26138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D26138: [clang-tidy] Add modernize-use-delete check

2016-10-31 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh, klimek. malcolm.parsons added subscribers: cfe-commits, danielmarjamaki. Herald added a subscriber: mgorny. Fixes PR27872 https://reviews.llvm.org/D26138 Files: clang-tidy/modernize/CMakeLists.txt