thakis closed this revision.
thakis added a comment.
285310
https://reviews.llvm.org/D26035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
Thanks! Landing…
Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224
+ // These already err, don't also warn.
+ !x &= 1; // expected-error{{expression is not assignable}}
+ !x |= 1; // expected-error{{expression is not assignable}}
-
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, very nice! (with one clarifying question)
Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224
+ // These already err, don't also warn.
+ !x &= 1; // expected-error{
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
This is a misspelling of the intended `!(x & A)` negated bit test that happens
in practice every now and then.
I ran this on Chromium and all its dependencies, and it fired 0 times -- no
false o
