[PATCH] D25731: [analyzer] NumberObjectConversion: Support CFNumberRef.

2016-10-18 Thread Anna Zaks via cfe-commits
zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:72 assert(Conv); - const Expr *Osboolean = Result.Nodes.getNodeAs("osboolean"); - const Expr *Nsnumber = Result.Nodes.getNodeAs("nsnumber"); - bool IsObjC = (bool)Nsnu

[PATCH] D25731: [analyzer] NumberObjectConversion: Support CFNumberRef.

2016-10-18 Thread Artem Dergachev via cfe-commits
NoQ created this revision. NoQ added reviewers: zaks.anna, dcoughlin. NoQ added a subscriber: cfe-commits. `CFNumberRef`, much like `NSNumber*`, can also be accidentally mistaken for a numeric value, so it is worth it to support this type in our new `NumberObjectConversion` checker. https://re