This revision was automatically updated to reflect the committed changes.
Closed by commit rL284430: [Driver] Use stem rather than filename for
executable name (authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D25700?vs=74905&id=74917#toc
Repository:
rL LLVM
https://re
bruno accepted this revision.
bruno added a comment.
Ok, thanks! LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek added a comment.
In https://reviews.llvm.org/D25700#572158, @bruno wrote:
> Can you add a testcase for that?
This is already covered by an existing testcase which was failing on Windows
(davide pointed that out to me).
Repository:
rL LLVM
https://reviews.llvm.org/D25700
davide added a comment.
And yes, if you can add a test case that will be great (there's no bot that
caught this upstream) but one of our internal bots did.
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-comm
bruno added a reviewer: bruno.
bruno added a comment.
Can you add a testcase for that?
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Was going to commit the same. Thanks. LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D25700
___
cfe-commits mailing list
cfe-commits@lists
phosek created this revision.
phosek added a reviewer: davide.
phosek added a subscriber: cfe-commits.
phosek set the repository for this revision to rL LLVM.
When comparing the linker name in Fuchsia driver, use stem rather than filename
to get the name of the linker becase on Windows, the filen
