This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL284236: [clang-move] Don't overuse Replacements::add.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25613?vs=74677&id=74679#toc
Repos
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Awesome! Lg with one nit.
Comment at: clang-move/ClangMove.cpp:197
clang::tooling::Replacement
getReplacementInChangedCode(const clang::tooling::Replacements &Replacements,
hokein updated this revision to Diff 74677.
hokein added a comment.
Delete one more function.
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.cpp
+++ c
hokein updated this revision to Diff 74675.
hokein added a comment.
woohoo, delete more code!
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.cpp
+++ c
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:472
std::string FilePath = RemoveReplacement.getFilePath().str();
addOrMergeReplacement(RemoveReplacement, &FileToReplacements[FilePath]);
For deletions, you can simply use `add`, whic
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25613
Files:
clang-move/ClangMove.cpp
Index: clang-move/ClangMove.cpp
===
--- clang-move/ClangMove.c
