rnk abandoned this revision.
rnk added a subscriber: majnemer.
rnk added a comment.
@majnemer did this in https://reviews.llvm.org/rL285544
https://reviews.llvm.org/D25581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
rsmith added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1037-1039
+llvm::APSInt AlignInBits;
+if (!E->getArg(1)->EvaluateAsInt(AlignInBits, CGM.getContext()))
+ break;
This takes the alignment in **bits**? That's so ridiculously dumb that
rnk created this revision.
rnk added a reviewer: rsmith.
rnk added a subscriber: cfe-commits.
GCC documents that the alignment parameter is in bits and it must be:
- an integer constant
- a power of two
- a multiple of CHAR_BITS
- below an unspecified limit
This lines up directly with the requir