This revision was automatically updated to reflect the committed changes.
Closed by commit rL284277: __builtin_fpclassify missing one int parameter
(authored by davidsh).
Changed prior to commit:
https://reviews.llvm.org/D25480?vs=74377&id=74740#toc
Repository:
rL LLVM
https://reviews.llvm.
taniabarg updated this revision to Diff 74377.
taniabarg added a comment.
Added test to test/Sema/builtin-unary-fp.c that will fail without the proposed
change (without the change, the test will -not- attempt to implicitly cast the
5th parameter to int).
https://reviews.llvm.org/D25480
Files:
hubert.reinterpretcast added a comment.
In https://reviews.llvm.org/D25480#567552, @ahatanak wrote:
> __builtin_fpclassify takes five int arguments followed by one last argument
> that is of floating point type. Do you know if there is a way to specify the
> last one argument is a floating poin
ahatanak added a comment.
__builtin_fpclassify takes five int arguments followed by one last argument
that is of floating point type. Do you know if there is a way to specify the
last one argument is a floating point rather than using '.'?
https://reviews.llvm.org/D25480
___
hubert.reinterpretcast added a comment.
A test should probably be added as well.
https://reviews.llvm.org/D25480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
taniabarg created this revision.
taniabarg added reviewers: davidsh, hubert.reinterpretcast.
taniabarg added a subscriber: cfe-commits.
BIF fpclassify has the wrong number of integer parameters specified in
Builtins.def. There should be 5 int parameters (each representing the values
FP_NAN, FP_I
