[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

This revision was automatically updated to reflect the committed changes. Closed by commit rL283767: Use unique_ptr in LLVMContextImpl's constant maps. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D25419?vs=74097&id=74206#toc Repository: rL LLVM https://reviews.ll

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

jlebar added inline comments. Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106 for (auto &CDSConstant : CDSConstants) delete CDSConstant.second; CDSConstants.clear(); jlebar wrote: > timshen wrote: > > Do you want to change this one as well? > Sure, but

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

jlebar marked an inline comment as done. jlebar added inline comments. Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106 for (auto &CDSConstant : CDSConstants) delete CDSConstant.second; CDSConstants.clear(); timshen wrote: > Do you want to change this o

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

timshen added inline comments. Comment at: llvm/lib/IR/LLVMContextImpl.cpp:106 for (auto &CDSConstant : CDSConstants) delete CDSConstant.second; CDSConstants.clear(); Do you want to change this one as well? https://reviews.llvm.org/D25419

[PATCH] D25419: Use unique_ptr in LLVMContextImpl's constant maps.

jlebar created this revision. jlebar added a reviewer: timshen. jlebar added a subscriber: cfe-commits. https://reviews.llvm.org/D25419 Files: llvm/lib/IR/Constants.cpp llvm/lib/IR/LLVMContextImpl.cpp llvm/lib/IR/LLVMContextImpl.h Index: llvm/lib/IR/LLVMContextImpl.h ==