[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Closed in rL283788. Repository: rL LLVM https://reviews.llvm.org/D25414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. @EricWF > Cool! This patch LGTM then. This looks fine to me, too. Repository: rL LLVM https://reviews.llvm.org/D25414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D25414#565956, @phosek wrote: > > That sounds fine. > > Shall I send it as a separate patch or update this one? I would send a separate patch. This one is already good to go so you might as well commit it. > > >> PS. If your not already lo

[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Petr Hosek via cfe-commits
phosek added a comment. > That sounds fine. Shall I send it as a separate patch or update this one? > PS. If your not already locked into an ABI you'll want to look into enabling > the most recent ABI breaking changes. See the `_LIBCPP_ABI_VERSION` > configuration at the top of `__config` for

[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Eric Fiselier via cfe-commits
EricWF added a comment. PS. If your not already locked into an ABI you'll want to look into enabling the most recent ABI breaking changes. See the `_LIBCPP_ABI_VERSION` configuration at the top of `__config` for more info. Repository: rL LLVM https://reviews.llvm.org/D25414 _

[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Cool! This patch LGTM then. > we're slowly diverging from the upstream version so it might be better to > stop relying on that option. I'd have to copy include/support/musl/xlocale.h > to inc

[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Petr Hosek via cfe-commits
phosek added a comment. Currently yes, we've been using libc++ (and libc++abi which doesn't need any changes) for a few months now without any problems. Our C library is a fork of musl so we rely on all the changes that have already been done to support it. However, we're building libc++ with `

[PATCH] D25414: [libcxx] Add support for Fuchsia

2016-10-10 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Is this *all* that's needed to get libc++ working? Repository: rL LLVM https://reviews.llvm.org/D25414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits