[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

2016-10-11 Thread Tom Stellard via cfe-commits
tstellarAMD added a comment. In https://reviews.llvm.org/D25343#565288, @Anastasia wrote: > Do you have any code example where Clang/LLVM performs wrong optimizations > with respect to the control flow of SPMD execution? > > My understanding from the earlier discussion we have had: > https://ww

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

2016-10-08 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. Do you have any code example where Clang/LLVM performs wrong optimizations with respect to the control flow of SPMD execution? My understanding from the earlier discussion we have had: https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg22643.html that nodupli

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

2016-10-07 Thread Brian Sumner via cfe-commits
b-sumner added a comment. clang does not recognize convergent as a valid attribute. There was an attempt to add this, see https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg22271.html but it hasn't had any result. Matt do you see "real uses" for this now? https://reviews.llvm.org/D2

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

2016-10-07 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D25343#564092, @arsenm wrote: > These should be convergent instead Unfortunately convergent is not supported as Clang attribute. There was patch to add it but the author withdrew it. Anastasia/Alexey, Do you think it is a good idea to add _

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

2016-10-06 Thread Matt Arsenault via cfe-commits
arsenm added a comment. These should be convergent instead https://reviews.llvm.org/D25343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits