CaseyCarter abandoned this revision.
CaseyCarter added a comment.
Ignoring the assignment from in_place_t issue for now, r283606 is good modulo a
couple of tiny things that I'll just email you directly.
https://reviews.llvm.org/D25249
___
cfe-commi
EricWF added a comment.
Addressed the issues about `in_place` SFINAE constraints in an inline comment.
Comment at: test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp:25
+// Test that any& operator=(ValueType&&) is *never* selected for:
+// * std::in_place type.
+
EricWF added a comment.
@CaseyCarter Thank you for the patch. I fixed most of your issues in r283606
{as well as a bunch of libc++ bugs).
I'm still deciding what to do about the `in_place` SFINAE tests, but I'll
follow up on that shortly. As for this patch please update it if there are any
fix
CaseyCarter added a comment.
I'll push a revision with the whitespace changes reverted soon.
> .gitignore:59
> keep.lst
> +.vscode/
This is an editor byproduct, I suppose, not "MSVC libraries test harness". Let
me know if anyone cares and I'll add a comment.
> any:553
> +__tmp._
CaseyCarter updated this revision to Diff 73538.
CaseyCarter added a comment.
Fix inadvertent whitespace changes.
https://reviews.llvm.org/D25249
Files:
.gitignore
include/any
test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp
test/libcxx/utilities/any/any.class/any.cons/valu
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
Changes to non-portable behavior in tests. Inline detailed description of
each change is forthcoming. Changes are almost entirely in test code, with one
behavioral c
