alexfh added inline comments.
Comment at: clang-tidy/google/NonConstReferences.cpp:73
+ [&](llvm::StringRef WhiteListType) {
+ return ReferencedType.getCanonicalType().getAsString(
+Result.Context->getPrintingP
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in rL283777.
https://reviews.llvm.org/D25244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein updated this revision to Diff 74138.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
https://reviews.llvm.org/D25244
Files:
clang-tidy/google/NonConstReferences.cpp
clang-tidy/google/NonConstReferences.h
docs/clang-tidy/checks/google-runtim
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a small nit.
Comment at: clang-tidy/google/NonConstReferences.cpp:71-75
+ for (const auto &WhiteListType: WhiteListTypes) {
+if (ReferencedType.g
hokein added a comment.
friendly ping. Aaron, could you take a look on this patch?
https://reviews.llvm.org/D25244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
https://reviews.llvm.org/D25244
Files:
clang-tidy/google/NonConstReferences.cpp
clang-tidy/google/NonConstReferences.h
docs/clang-tidy/checks/google-runtime-references.rst
test/cl
