ahatanak added a comment.
Thanks all for the review.
Comment at: cfe/trunk/test/SemaCXX/lambda-expressions.cpp:572
+void foo1() {
+ auto s0 = S1{[name=]() {}}; // expected-error 2 {{expected expression}}
+ auto s1 = S1{[name=name]() {}}; // expected-error {{use of undeclared
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290156: [Parser] Correct typo after lambda capture
initializer is parsed. (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D25206?vs=75819&id=82052#toc
Repository:
rL LLVM
h
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
This looks good to me. It would be nice if we could get rid of the 2nd
`expected expression` error in `auto s0 = S1{[name=]() {}};`, but it can be
done later.
https://reviews.llvm.org/D2
ahatanak added a comment.
Are there any further comments?
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 75819.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Skip the step to correct typo if ParseInitializer returns ExprError(). Add a
test case that exercises the change.
https://reviews.llvm.org/D25206
Files:
lib/Parse/ParseExprCXX.c
mehdi_amini added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
rsmith wrote:
> ahatanak wrote:
> > mehdi_amini wrote:
> > > What happens when t
rsmith added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
ahatanak wrote:
> mehdi_amini wrote:
> > What happens when there is no typo correctio
ahatanak added reviewers: bruno, erik.pilkington, majnemer.
ahatanak added a comment.
Add more reviewers.
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
ahatanak added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
mehdi_amini wrote:
> What happens when there is no typo correction to apply?
If the
mehdi_amini added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:951
Init = ParseInitializer();
+ Init = Actions.CorrectDelayedTyposInExpr(Init.get());
What happens when there is no typo correction to apply?
https://reviews.llvm.o
ahatanak added a comment.
ping
https://reviews.llvm.org/D25206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak created this revision.
ahatanak added a reviewer: rsmith.
ahatanak added a subscriber: cfe-commits.
This fixes PR30566.
The assertion is triggered when RecordLayoutBuilder tries to compute the size
of a field (for capture "name" in the test case) whose type hasn't been
deduced. This fi
12 matches
Mail list logo
