[PATCH] D25053: [libc++] Correct alignment condition

2016-10-07 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 283621 https://reviews.llvm.org/D25053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25053: [libc++] Correct alignment condition

2016-10-04 Thread Marshall Clow via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. I will land this, and close the other one, too. https://reviews.llvm.org/D25053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D25053: [libc++] Correct alignment condition

2016-09-30 Thread Shoaib Meenai via cfe-commits
smeenai added a comment. @mclow.lists Do you have any preference between this and https://reviews.llvm.org/D14259? I'm fine either way, but I'd want one of them to be committed sooner rather than later. https://reviews.llvm.org/D25053 ___ cfe-comm

Re: [PATCH] D25053: [libc++] Correct alignment condition

2016-09-28 Thread Shoaib Meenai via cfe-commits
smeenai added a comment. It's not – I just wasn't aware of the existence of the other one :) That one's been stagnant for a long time though. One of these changes should be abandoned in favor of the other, and I'm fine doing it either way. https://reviews.llvm.org/D25053 ___

Re: [PATCH] D25053: [libc++] Correct alignment condition

2016-09-28 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. How is this different from https://reviews.llvm.org/D14259 ?? https://reviews.llvm.org/D25053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25053: [libc++] Correct alignment condition

2016-09-28 Thread Shoaib Meenai via cfe-commits
smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The max alignment is a PE/COFF restriction, not an MSVC-specific restriction; it also applies to gcc and clang when compiling for Windows. Change the conditional to _WIN3