aprantl added a comment.
In https://reviews.llvm.org/D24998#932061, @torarnv wrote:
> This seems to have hit a recent Xcode toolchain (Xcode 9.1 ?).
>
> Xcode now complains that "[app name] was compiled with optimization -
> stepping may behave oddly; variables may not be available.", when launc
torarnv added a comment.
This seems to have hit a recent Xcode toolchain (Xcode 9.1 ?).
Xcode now complains that "[app name] was compiled with optimization - stepping
may behave oddly; variables may not be available.", when launching a debug
session, which seems to be the case, debugging is all
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
I agree with Keith. This is a starting point, not a final destination.
As we evolve this, we can start looking at better ways to improve the debug
illusion, but right now, `O1` is probably
sylvestre.ledru updated this revision to Diff 77023.
Herald added a subscriber: mehdi_amini.
https://reviews.llvm.org/D24998
Files:
docs/CommandGuide/clang.rst
lib/Frontend/CompilerInvocation.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
keith.walker.arm added a comment.
Looking into what optimisations would be relevant to -Og (or rather what
optimisation should be omitted because they are too disruptive to the debug
experience) is something that I have on my road-map as something to look into
and gather feedback on.
I agree t
probinson added a comment.
As Renato points out, this addresses the user experience of tripping over the
lack of -Og, however it does not really address the intent of PR20765 which is
to provide a mode of optimizations that don't particularly interfere with
debugging.
Eventually someone needs t
dblaikie added inline comments.
> debug-options.c:21-22
>
> +// RUN: %clang -### -c -Og -g %s -target x86_64-linux-gnu 2>&1 \
> +// RUN: | FileCheck -check-prefix=G -check-prefix=G_GDB %s
> +
I don't think we need this test case: -Og doesn't actually have anything to do
with -g me
rengolin added reviewers: echristo, dberlin, keith.walker.arm.
rengolin added a comment.
Hi Sylvestre,
Paul's comments on the bug are still pertinent: `-Og` is not the same as `-O1`.
`-Og` means for "optimised for debuggers" which is short for "preserve the
debug illusion without bloating the c
sylvestre.ledru updated this revision to Diff 72759.
sylvestre.ledru added a comment.
with the full context + clang format
https://reviews.llvm.org/D24998
Files:
docs/CommandGuide/clang.rst
lib/Frontend/CompilerInvocation.cpp
test/Driver/debug-options.c
test/Preprocessor/init.c
Index:
majnemer added a subscriber: majnemer.
majnemer added a comment.
Please include full context with your diff.
Comment at: lib/Frontend/CompilerInvocation.cpp:101-103
@@ -100,1 +100,5 @@
+if (S == "g") {
+return 1;
+}
+
Please clang-format this.
sylvestre.ledru created this revision.
sylvestre.ledru added a reviewer: rengolin.
sylvestre.ledru added a subscriber: cfe-commits.
Just like gcc, we should have the -Og option as more and more software are
using it:
https://llvm.org/bugs/show_bug.cgi?id=20765
https://reviews.llvm.org/D24998
Fi
11 matches
Mail list logo
