[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

This revision was automatically updated to reflect the committed changes. Closed by commit rL336008: Request init/fini array on FreeBSD 12 and later (authored by dim, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D24867?vs=72282&id=15

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

bsdjhb added a comment. Ping. I'd like this to go in and get merged into FreeBSD's clang so we can test this for a few months before 12.0 branches. https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

arichardson accepted this revision. arichardson added a comment. I recently made this change for the CHERI clang fork and as far as I can tell everything works fine. https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

brooks accepted this revision. brooks added a comment. I do think we should make this change, but don't have a strong opinion on the timing. If we do it for 12 and not 13 then we should probably try to get it into a 6.0.2. https://reviews.llvm.org/D24867 ___

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

dim added a comment. Brooks, I can commit this if you prefer. Maybe it can go into 6.0.2 still... https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

brooks added a reviewer: arichardson. brooks added a comment. Herald added a subscriber: krytarowski. Adding Alex as he made some related changes to CHERI Clang recently https://github.com/CTSRD-CHERI/clang/commit/3a648766deabb4ff7f95862213c3c99e7223363c. https://reviews.llvm.org/D24867

Re: [PATCH] D24867: Request init/fini array on FreeBSD 12 and later

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D24867: Request init/fini array on FreeBSD 12 and later

emaste created this revision. emaste added reviewers: dim, brooks. emaste added a subscriber: cfe-commits. Herald added a subscriber: emaste. It seems a bad idea to change the default in the middle of a release branch due to possible changes in global ctor / dtor ordering between .ctors and .ini