Re: [PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags

2016-09-26 Thread Michał Górny via cfe-commits
mgorny added a comment. In https://reviews.llvm.org/D24809#553415, @EricWF wrote: > > Stop stripping -m32 from the user-supplied flags. There is no valid reason > > to do that, stripping it silently is thoroughly confusing and makes it > > impossible to do distribution multi-ABI builds without

Re: [PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags

2016-09-26 Thread Eric Fiselier via cfe-commits
EricWF added a comment. > Stop stripping -m32 from the user-supplied flags. There is no valid reason to > do that, stripping it silently is thoroughly confusing and makes it > impossible to do distribution multi-ABI builds without resorting to ugly > hacks. The reason for stripping it is conf

[PATCH] D24809: [libcxx] [cmake] Stop stripping -m32 from compiler flags

2016-09-21 Thread Michał Górny via cfe-commits
mgorny created this revision. mgorny added a reviewer: EricWF. mgorny added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. Stop stripping -m32 from the user-supplied flags. There is no valid reason to do that, stripping it silently is thoroughly confusing and makes it impossi