Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282146: [change-namespace] fix qualifier of function references. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D24803?vs=72145&id=72152#toc Repository: rL LLVM https://revi

Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 72145. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressing review comments: added a test case for out-of-line static method and fixed a bug. https://reviews.llvm.org/D24803 Files: change-namespace/ChangeNamespace.cpp unittests/

Re: [PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-22 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: change-namespace/ChangeNamespace.cpp:290 @@ +289,3 @@ + // namespace. + // Note that the matcher does not exlude calls to out-of-line static method + // definitions, so we need to exclude them in the callback handler. s

[PATCH] D24803: [change-namespace] fix qualifier of function references.

2016-09-21 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: hokein. ioeric added a subscriber: cfe-commits. https://reviews.llvm.org/D24803 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp ==