Thanks for clarification!
You are right that it doesn't really fit in -Wignored-pragma, but I
also don't like the idea of getting warning about ignored "#pragma
intrinsic" after setting -Wno-ignored-pragma, so I think I'll leave it
as it is.
On Wed, Sep 21, 2016 at 1:35 PM, Nico Weber wrote:
> On
On Tue, Sep 20, 2016 at 4:21 PM, Albert Gutowski
wrote:
> OK, thanks for the note about referring to Chromium, I fixed that.
> As to -Wunknown-pragma, I feel that it would be inconsistent with other
> pragmas unless I moved whole pragma to lexer instead of parser - I've just
> discovered that I c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL282108: Add -Wignored-pragma-intrinsic flag (authored by
agutowski).
Changed prior to commit:
https://reviews.llvm.org/D24775?vs=71960&id=72102#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2477
OK, thanks for the note about referring to Chromium, I fixed that.
As to -Wunknown-pragma, I feel that it would be inconsistent with other
pragmas unless I moved whole pragma to lexer instead of parser - I've just
discovered that I can do that, how should I decide if it's supposed to be
here or the
Thanks! Some bikesheddy comments, ignore as you see fit:
- I think it's good to keep Chromium's bug tracker out of LLVM as far as
possible (most LLVM devs don't need to care about Chromium, and since
Chromium's bug tracker refers to LLVM's bug tracker frequently since
chromium depends on llvm, add
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm!
https://reviews.llvm.org/D24775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
agutowski created this revision.
agutowski added reviewers: thakis, hans.
agutowski added a subscriber: cfe-commits.
https://bugs.chromium.org/p/chromium/issues/detail?id=644841#c9
https://reviews.llvm.org/D24775
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticPa
