Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-26 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. r282447 https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-26 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. Ping, can someone commit this one now? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-21 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. Can someone commit this patch now after it has been rebased? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-21 Thread Martin Storsjö via cfe-commits
mstorsjo updated the summary for this revision. mstorsjo updated this revision to Diff 72025. mstorsjo added a comment. Rebased on top of the latest master https://reviews.llvm.org/D24609 Files: lib/Headers/intrin.h Index: lib/Headers/intrin.h

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-20 Thread Saleem Abdulrasool via cfe-commits
compnerd added a comment. Im happy to do so, but, could you please rebase the patch? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-20 Thread Martin Storsjö via cfe-commits
mstorsjo added a comment. Thanks! Can you/someone commit it? https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-19 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. That sounds reasonable. https://reviews.llvm.org/D24609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-17 Thread Martin Storsjö via cfe-commits
mstorsjo added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1; -

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-16 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1; -

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-16 Thread Martin Storsjö via cfe-commits
mstorsjo added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1; -

Re: [PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-15 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: lib/Headers/intrin.h:504 @@ +503,3 @@ +_interlockedbittestandset_acq(long volatile *_BitBase, long _BitPos) { + long _PrevVal = __atomic_fetch_or(_BitBase, 1l << _BitPos, __ATOMIC_ACQUIRE); + return (_PrevVal >> _BitPos) & 1; -

[PATCH] D24609: [ARM] Add missing Interlocked intrinsics

2016-09-15 Thread Martin Storsjö via cfe-commits
mstorsjo created this revision. mstorsjo added a reviewer: compnerd. mstorsjo added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. On ARM, there are multiple versions of each of the intrinsics, with acquire/relaxed/release barrier semantics. The 64 bit versio