On 18 October 2016 at 12:08, Eric Liu wrote:
> clang-apply-replacements has some legacy code and needs some refactoring
> in order to take advantage of the cleanup feature (because of the new
> tooling::Replacements implementation). I had a plan to refactor it but
> thought it was a low priority
clang-apply-replacements has some legacy code and needs some refactoring in
order to take advantage of the cleanup feature (because of the new
tooling::Replacements implementation). I had a plan to refactor it but
thought it was a low priority since most refactoring tools are using
replacements app
malcolm.parsons added a comment.
Does clang-apply-replacements need a similar change?
Repository:
rL LLVM
https://reviews.llvm.org/D24572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284399: [clang-tidy] Clean up code after applying
replacements. (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D24572?vs=74160&id=74868#toc
Repository:
rL LLVM
https://revie
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D24572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
alexfh updated this revision to Diff 74160.
alexfh marked 6 inline comments as done.
alexfh added a comment.
Herald added subscribers: mgorny, beanz.
- Addressed review comments
https://reviews.llvm.org/D24572
Files:
clang-tidy/CMakeLists.txt
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyD
hokein added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:206
@@ +205,3 @@
+StringRef Code = Buffer.get()->getBuffer();
+format::FormatStyle Style = format::getLLVMStyle();
+llvm::Expected CleanReplacements =
ioeric wrote:
> Add a
ioeric requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/ClangTidy.cpp:25
@@ -24,2 +24,3 @@
#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Format/Format.h"
#include "clang/Frontend/ASTConsumers.h"
--
alexfh created this revision.
alexfh added reviewers: ioeric, hokein.
alexfh added a subscriber: cfe-commits.
Remove empty namespaces and initializer list commas / colons in
affected ranges. A strawman patch: proper options for enabling the cleanup and
specifying the format style are needed.
http
