Re: [PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

2016-09-16 Thread Kirill Bobyrev via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281710: [clang-rename] Merge rename-{at|all} & optimise. (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24567?vs=71367&id=71600#toc Repository: rL LLVM https://reviews.llv

Re: [PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

2016-09-16 Thread Kirill Bobyrev via cfe-commits
omtcyfz added a comment. In https://reviews.llvm.org/D24567#543459, @vmiklos wrote: > As mentioned earlier, I have no problem with merging rename-at and rename-all. Good, thanks! https://reviews.llvm.org/D24567 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

2016-09-15 Thread Miklos Vajna via cfe-commits
vmiklos added a comment. As mentioned earlier, I have no problem with merging rename-at and rename-all. https://reviews.llvm.org/D24567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

2016-09-14 Thread Kirill Bobyrev via cfe-commits
omtcyfz created this revision. omtcyfz added reviewers: alexfh, vmiklos. omtcyfz added a subscriber: cfe-commits. Having both rename-at and rename-all both seems confusing and introduces unneeded difficulties. After merging rename-at and rename-all maintaining main function wrappers and custom h