[PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-30 Thread Bruno Cardoso Lopes via cfe-commits
bruno closed this revision. bruno added a comment. Thanks Reid & Akira, Committed r282968 https://reviews.llvm.org/D24472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-30 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm > SemaExpr.cpp:8084 > +// type. Note that this is already done by non-compound assignments in > +// CheckAssignmentConstraints. If it's a scalar type, only biscast for > +// <1 x T

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-28 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. @rnk, do you have any concerns about this patch? https://reviews.llvm.org/D24472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-23 Thread Bruno Cardoso Lopes via cfe-commits
bruno added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8090 @@ +8089,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return VecType; +} ahatanak wrote: > Sorry I wasn't clear, but I was asking whether you were plan

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-21 Thread Akira Hatanaka via cfe-commits
ahatanak added a comment. Thanks Bruno. I have a couple more questions. Comment at: lib/Sema/SemaExpr.cpp:8090 @@ +8089,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return VecType; +} Sorry I wasn't clear, but I was a

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-19 Thread Bruno Cardoso Lopes via cfe-commits
bruno updated this revision to Diff 71870. bruno added a comment. Update again (now with the right patch) after Akira's comment https://reviews.llvm.org/D24472 Files: lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c Index: test/Sema/vector-cast.c ==

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-19 Thread Bruno Cardoso Lopes via cfe-commits
bruno updated this revision to Diff 71869. bruno marked an inline comment as done. bruno added a comment. Update after Akira's comment https://reviews.llvm.org/D24472 Files: lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c Index: test/Sema/vector-cast.c ===

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-19 Thread Bruno Cardoso Lopes via cfe-commits
bruno marked an inline comment as done. Comment at: lib/Sema/SemaExpr.cpp:8084 @@ +8083,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return LHSType; +} ahatanak wrote: > My understanding is that, when we have a compound

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-19 Thread Akira Hatanaka via cfe-commits
ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:8084 @@ +8083,3 @@ + *RHSExpr = ImpCastExprToType(RHSExpr->get(), LHSType, CK_BitCast); + return LHSType; +} My understanding is that, when we have a compound assign like "LHS += RHS",

Re: [PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-16 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a comment. Ping! https://reviews.llvm.org/D24472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24472: [Sema] Support lax conversions for compound assignments

2016-09-12 Thread Bruno Cardoso Lopes via cfe-commits
bruno created this revision. bruno added a reviewer: rnk. bruno added subscribers: cfe-commits, ahatanak. Support lax conversions on compound assignment expressions like: typedef __attribute__((vector_size(8))) double float64x1_t; typedef __attribute__((vector_size(16))) double float64x2_t;