djasper closed this revision.
djasper added a comment.
Submitted as r280874.
https://reviews.llvm.org/D24322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added inline comments.
Comment at: lib/Format/Format.cpp:1707
@@ +1706,3 @@
+ if (NewCode) {
+auto NewEnv = Environment::CreateVirtualEnvironment(
+*NewCode, FileName,
mprobst wrote:
> I guess we don't worry about the performance c
mprobst added inline comments.
Comment at: lib/Format/Format.cpp:1707
@@ +1706,3 @@
+ if (NewCode) {
+auto NewEnv = Environment::CreateVirtualEnvironment(
+*NewCode, FileName,
I guess we don't worry about the performance consequences here?
djasper created this revision.
djasper added a reviewer: mprobst.
djasper added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The attempt to fix requoting behavior in r280487 after changes to
tooling::Replacements are incomplete. We essentially need to add to
replacements at the