Re: [PATCH] D24312: [CodeGen] Fix an assert in EmitNullConstant

2016-09-13 Thread Akira Hatanaka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281405: [CodeGen] Fix an assert in EmitNullConstant. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D24312?vs=70589&id=71248#toc Repository: rL LLVM https://reviews.llvm.o

Re: [PATCH] D24312: [CodeGen] Fix an assert in EmitNullConstant

2016-09-09 Thread John McCall via cfe-commits
rjmccall added a comment. LGTM. https://reviews.llvm.org/D24312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24312: [CodeGen] Fix an assert in EmitNullConstant

2016-09-07 Thread Akira Hatanaka via cfe-commits
ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a subscriber: cfe-commits. r235815 changed CGRecordLowering::accumulateBases to ignore non-virtual bases of size 0, which prevented adding those non-virtual bases to CGRecordLayout's NonVirtualBases. EmitNullCons