Re: [PATCH] D24099: [libc++] Don't add -fPIC on Windows

2016-09-01 Thread Saleem Abdulrasool via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r280413 https://reviews.llvm.org/D24099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24099: [libc++] Don't add -fPIC on Windows

2016-09-01 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D24099: [libc++] Don't add -fPIC on Windows

2016-08-31 Thread Shoaib Meenai via cfe-commits
smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. -fPIC doesn't make much sense for Windows, since Windows DLLs aren't compiled position independent and are instead relocated at runtime instead. https://reviews.llvm.org