krememek added a comment.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285657: [ReachableCode] Skip over ExprWithCleanups in
isConfigurationValue (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D24010?vs=75644&id=76508#toc
Repository:
rL LLVM
h
srhines added a comment.
Ping. Other developers (Firefox) are now starting to hit this issue.
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ah, right - thanks for reminding/explaining!
On Mon, Oct 24, 2016 at 2:42 PM Tim Shen wrote:
> On Mon, Oct 24, 2016 at 2:38 PM David Blaikie wrote:
>
> Simplify it further by replacing A() with just a function instead of a
> class? Or does that break the repro?
>
> bool Foo();
> void Bar();
> v
On Mon, Oct 24, 2016 at 2:38 PM David Blaikie wrote:
> Simplify it further by replacing A() with just a function instead of a
> class? Or does that break the repro?
>
> bool Foo();
> void Bar();
> void Baz() {
> if (False && Foo())
> Bar();
> }
>
This actually breaks the repro. My test int
Simplify it further by replacing A() with just a function instead of a
class? Or does that break the repro?
bool Foo();
void Bar();
void Baz() {
if (False && Foo())
Bar();
}
On Mon, Oct 24, 2016 at 1:38 PM Tim Shen wrote:
> On Mon, Oct 24, 2016 at 10:33 AM David Blaikie wrote:
>
> On Mon
On Mon, Oct 24, 2016 at 10:33 AM David Blaikie wrote:
> On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> timshen created this revision.
> timshen added reviewers: rsmith, pirama.
> timshen added a subscriber: cfe-commits.
>
> https://reviews.llvm
timshen updated this revision to Diff 75644.
timshen added a comment.
Simplified the test.
https://reviews.llvm.org/D24010
Files:
clang/include/clang/AST/Stmt.h
clang/lib/Analysis/ReachableCode.cpp
clang/test/SemaCXX/PR29152.cpp
Index: clang/test/SemaCXX/PR29152.cpp
On Mon, Aug 29, 2016 at 3:45 PM Tim Shen via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> timshen created this revision.
> timshen added reviewers: rsmith, pirama.
> timshen added a subscriber: cfe-commits.
>
> https://reviews.llvm.org/D24010
>
> Files:
> clang/include/clang/AST/Stmt.h
>
srhines added a comment.
This looks good to me, but I would prefer if one of the more experienced Clang
folks could officially LGTM this. Thanks.
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
pirama added a comment.
Ping... I am not the author of this patch, but am interested in seeing the
issue fixed :)
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
pirama added a subscriber: srhines.
pirama added a comment.
Tim: Thanks for looking into this. It's definitely a simpler fix than I
thought it would be :)
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
timshen created this revision.
timshen added reviewers: rsmith, pirama.
timshen added a subscriber: cfe-commits.
https://reviews.llvm.org/D24010
Files:
clang/include/clang/AST/Stmt.h
clang/lib/Analysis/ReachableCode.cpp
clang/test/SemaCXX/PR29152.cpp
Index: clang/test/SemaCXX/PR29152.cpp
=
13 matches
Mail list logo
