Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-09-07 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280825: Parsing MS pragma intrinsic (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D23944?vs=69768&id=70551#toc Repository: rL LLVM https://reviews.llvm.org/D23944 Files: cfe

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-30 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. lgtm https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-30 Thread Albert Gutowski via cfe-commits
agutowski marked an inline comment as done. agutowski added a comment. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-30 Thread Albert Gutowski via cfe-commits
agutowski updated this revision to Diff 69768. agutowski added a comment. Fixed typo https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/IdentifierTable.h include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp test/Preprocessor/pragma

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-30 Thread Albert Gutowski via cfe-commits
agutowski updated this revision to Diff 69767. agutowski added a comment. Fixed checking if the function is an intrinsic. Updated getBuiltinID description. https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/IdentifierTable.h include/cla

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-30 Thread Reid Kleckner via cfe-commits
rnk added a comment. One buglet, otherwise looks good. Comment at: lib/Parse/ParsePragma.cpp:2169 @@ +2168,3 @@ +IdentifierInfo *II = Tok.getIdentifierInfo(); +if (II->getBuiltinID() < 2) + PP.Diag(Tok.getLocation(), diag::warn_pragma_intrinsic_builtin)

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-30 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should wait for @rnk to accept as well. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-29 Thread Albert Gutowski via cfe-commits
agutowski marked 4 inline comments as done. agutowski added a comment. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-29 Thread Albert Gutowski via cfe-commits
agutowski updated this revision to Diff 69632. agutowski added a comment. Changed warning template to use select, fixed some mistakes in the comments. https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-29 Thread Albert Gutowski via cfe-commits
agutowski added inline comments. Comment at: lib/Parse/ParsePragma.cpp:2164 @@ +2163,3 @@ + + bool SuggestIntrinH = !PP.isMacroDefined("__INTRIN_H"); + aaron.ballman wrote: > Is this safe to rely on? I'm not familiar with how we do our intrinsics, but > it's spe

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-29 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: include/clang/Basic/DiagnosticParseKinds.td:918 @@ +917,3 @@ + InGroup; +def warn_pragma_intrinsic_builtin_suggest : Warning< + "%0 is not a recognized builtin; consider i

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-29 Thread Albert Gutowski via cfe-commits
agutowski marked 2 inline comments as done. agutowski added a comment. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-29 Thread Albert Gutowski via cfe-commits
agutowski updated this revision to Diff 69605. agutowski added a comment. Changed warning messages https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp test/Preprocessor/pragma_microsoft.c Index: lib/P

Re: [PATCH] D23944: Parsing MS pragma intrinsic

2016-08-29 Thread Reid Kleckner via cfe-commits
rnk added inline comments. Comment at: include/clang/Basic/DiagnosticParseKinds.td:916 @@ +915,3 @@ +def warn_pragma_expected_builtin : Warning< + "expected builtin function in '#pragma %0' - ignored">, + InGroup; I'd use this wording: '%0' is not a recognized