mgorny abandoned this revision.
mgorny added a comment.
Very well. I'll look into (ab)using the existing options to achieve the same
result. Having stand-alone build systems, this should become easier these days,
at least until some major change in runtime handling occurs.
https://reviews.llvm
chandlerc added a comment.
In https://reviews.llvm.org/D23752#581436, @mgorny wrote:
> This really doesn't solve the problems we have. We don't want to build and
> install two almost-identical copies of compiler-rt and clang headers, when we
> can just build one and make clang use it.
However
mgorny added a comment.
This really doesn't solve the problems we have. We don't want to build and
install two almost-identical copies of compiler-rt and clang headers, when we
can just build one and make clang use it.
https://reviews.llvm.org/D23752
chandlerc added a comment.
In https://reviews.llvm.org/D23752#581427, @mgorny wrote:
> In https://reviews.llvm.org/D23752#581416, @chandlerc wrote:
>
> > I don't get it.
> >
> > There is nothing "RUNTIMES" about it. And this variable is actually used to
> > produce real libraries: libclang, etc.
mgorny added a comment.
In https://reviews.llvm.org/D23752#581416, @chandlerc wrote:
> I don't get it.
>
> There is nothing "RUNTIMES" about it. And this variable is actually used to
> produce real libraries: libclang, etc.
>
> It's just the LIBDIR_SUFFIX. That's it. The reason it is called
> C
chandlerc added a comment.
I don't get it.
There is nothing "RUNTIMES" about it. And this variable is actually used to
produce real libraries: libclang, etc.
It's just the LIBDIR_SUFFIX. That's it. The reason it is called
CLANG_LIBDIR_SUFFIX and set from LLVM_LIBDIR_SUFFIX is to support using
beanz added a comment.
This looks like it is in the direction I would expect. Please let me know once
the final patch is ready.
Comment at: lib/Driver/Tools.cpp:2021
std::string Plugin =
- ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so";
+
mgorny added inline comments.
Comment at: lib/Driver/Tools.cpp:2021
std::string Plugin =
- ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so";
+ ToolChain.getDriver().Dir + "/../lib" LLVM_RUNTIMES_LIBDIR_SUFFIX
"/LLVMgold.so";
CmdArgs.push_b
mgorny retitled this revision from "cmake: Supporting overriding runtime libdir
via CLANG_LIBDIR_SUFFIX" to "[cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 75996.
mgorny added a comment.
Here's the initial patch for
