Re: [PATCH] D23720: Omit column info for CodeView by default

2016-08-25 Thread Adrian McCarthy via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL279765: Omit column info for CodeView by default (authored by amccarth). Changed prior to commit: https://reviews.llvm.org/D23720?vs=68713&id=69274#toc Repository: rL LLVM https://reviews.llvm.org/D

Re: [PATCH] D23720: Omit column info for CodeView by default

2016-08-25 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23720: Omit column info for CodeView by default

2016-08-19 Thread Adrian McCarthy via cfe-commits
amccarth created this revision. amccarth added a subscriber: cfe-commits. Clang tracks only start columns, not start-end ranges. CodeView allows for that, but the VS debugger doesn't handle anything less than a complete range well--it either highlights the wrong part of a statement or truncates