Re: [PATCH] D23692: Interpret strlen as constexpr for GCC Compatibility

2016-08-19 Thread Erich Keane via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D23692#520097, @erichkeane wrote: > In https://reviews.llvm.org/D23692#520081, @rsmith wrote: > > > This is not a conforming extension. We are explicitly not allowed to make > > standard library functions `constexpr` if the standard doesn't

Re: [PATCH] D23692: Interpret strlen as constexpr for GCC Compatibility

2016-08-18 Thread Erich Keane via cfe-commits
erichkeane abandoned this revision. erichkeane added a comment. In https://reviews.llvm.org/D23692#520081, @rsmith wrote: > This is not a conforming extension. We are explicitly not allowed to make > standard library functions `constexpr` if the standard doesn't say they are; > see [constexpr.f

Re: [PATCH] D23692: Interpret strlen as constexpr for GCC Compatibility

2016-08-18 Thread Richard Smith via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This is not a conforming extension. We are explicitly not allowed to make standard library functions `constexpr` if the standard doesn't say they are; see [constexpr.functions] (17.6

[PATCH] D23692: Interpret strlen as constexpr for GCC Compatibility

2016-08-18 Thread Erich Keane via cfe-commits
erichkeane created this revision. erichkeane added reviewers: cfe-commits, majnemer, vbyakovl, DavidKreitzer, andreybokhanko, rsmith. erichkeane set the repository for this revision to rL LLVM. GCC (and other compilers) treat strlen as a 'constexpr' function as an extension to the language. Cla