compnerd closed this revision.
compnerd added a comment.
SVN r279173
https://reviews.llvm.org/D23530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexshap updated this revision to Diff 68128.
alexshap added a comment.
Address code review comment
https://reviews.llvm.org/D23530
Files:
lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
Index: lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
==
alexshap added a comment.
Yes: "Data, Length, Val" would work as well, i will update this diff
https://reviews.llvm.org/D23530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd added a comment.
The `Data` and `Length` fields are tied together. Wouldn't it be possible to
reorder this as `Val`, `Length`, `Data` and have it achieve similar sizes and
keep the `Data` and `Length` fields together?
https://reviews.llvm.org/D23530
__
