Re: [PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

2016-08-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278444: [Basic] Add const qualifier to SM.isInSystemMacro (NFC) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D23433?vs=67737&id=67781#toc Repository: rL LLVM https://revi

Re: [PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

2016-08-11 Thread Visoiu Mistrih Francis via cfe-commits
thegameg added a comment. Thanks @vsk. As I don't have commit access, is it possible to commit this for me, please? Thanks. https://reviews.llvm.org/D23433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

2016-08-11 Thread Visoiu Mistrih Francis via cfe-commits
thegameg created this revision. thegameg added reviewers: joker-eph, vsk, dblaikie. thegameg added a subscriber: cfe-commits. The member function is a predicate, and doesn't apply any changes on the object. https://reviews.llvm.org/D23433 Files: include/clang/Basic/SourceManager.h Index: incl

Re: [PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

2016-08-11 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Makes sense. isMacroID and isInSystemHeader are both already marked const. https://reviews.llvm.org/D23433 ___ cfe-commits mailing list cfe-commits@lis