Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

2016-08-10 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278206: Make clang-format remove duplicate headers when sorting #includes. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D23274?vs=67489&id=67492#toc Repository: rL LLVM ht

Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

2016-08-10 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D23274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

2016-08-10 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 67489. ioeric marked 3 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D23274 Files: lib/Format/Format.cpp test/Format/remove-duplicate-includes.cpp tools/clang-format/ClangFormat.cpp unittests/F

Re: [PATCH] D23274: Make clang-format remove duplicate headers when sorting #includes.

2016-08-10 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: lib/Format/Format.cpp:1224 @@ -1222,1 +1223,3 @@ +// Finds the index of the #include on which the cursor will be put after +// sorting/deduplicating. First off, make this return a pair with the two values. And then the