This revision was automatically updated to reflect the committed changes.
Closed by commit rL278099: [clang-rename] fix bug with initializer lists
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23193?vs=67289&id=67290#toc
Repository:
rL LLVM
https://reviews.llvm.o
omtcyfz updated this revision to Diff 67289.
omtcyfz marked an inline comment as done.
omtcyfz added a comment.
`auto` -> `SourceLocation`
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
The test is fine now. Looks good once the other comment is addressed.
https://reviews.llvm.org/D23193
___
cfe-commits mailing list
cfe-commits@li
omtcyfz updated this revision to Diff 67199.
omtcyfz added a comment.
Added more info to the test.
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/Field.cpp
==
alexfh added a comment.
In https://reviews.llvm.org/D23193#508563, @omtcyfz wrote:
> Do these symbolic pointers in test seem reasonable?
Yes, kind of. I'd change these to C-style comments, place them on the same line
with the interesting identifier (probably, right after the identifier), and
omtcyfz updated this revision to Diff 67165.
omtcyfz added a comment.
Do these symbolic pointers seem reasonable?
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/Field.cpp
Index: test/clang-rename/Field.cpp
===
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-rename/USRFinder.cpp:100
@@ +99,3 @@
+ if (const clang::FieldDecl *FieldDecl = Initializer->getMember()) {
+const auto InitBeginL
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Wait, please add a test.
https://reviews.llvm.org/D23193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
omtcyfz created this revision.
omtcyfz added a reviewer: alexfh.
omtcyfz added a subscriber: cfe-commits.
`clang-rename` is currently not able to find a symbol in initializer list. This
patch is a fix of that bug.
https://reviews.llvm.org/D23193
Files:
clang-rename/USRFinder.cpp
clang-renam
