Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

2016-08-03 Thread Kirill Bobyrev via cfe-commits
This revision was automatically updated to reflect the committed changes. omtcyfz marked an inline comment as done. Closed by commit rL277663: [clang-rename] improve USRFindingAction (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D23058?vs=66670&id=66728#toc Repositor

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

2016-08-03 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D23058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

2016-08-03 Thread Kirill Bobyrev via cfe-commits
omtcyfz marked 2 inline comments as done. Comment at: test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:3 @@ +2,3 @@ +// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s + alexfh wrote:

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

2016-08-03 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 66670. omtcyfz added a comment. Merged multiple identical tests into a single test with multiple `clang-rename` invocations. https://reviews.llvm.org/D23058 Files: clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp test/clang-rename/Complex

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

2016-08-03 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2 @@ -1,3 +1,3 @@ // RUN: cat %s > %t.cpp -// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i -- +// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i -- // RUN:

Re: [PATCH] D23058: [clang-rename] improve USRFindingAction

2016-08-03 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 66642. omtcyfz added a comment. Removed `dump()` call used for debugging purposes. Removed unneeded header inclusion in `USRFindingAction.cpp`. https://reviews.llvm.org/D23058 Files: clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp test/cl