This revision was automatically updated to reflect the committed changes.
Closed by commit rL277356: [clang-rename] handle overridden functions correctly
(authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23009?vs=66338&id=66340#toc
Repository:
rL LLVM
https://reviews
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D23009
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
omtcyfz updated this revision to Diff 66338.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D23009
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/FunctionOverride.cpp
Index: test/clang-rename/FunctionOverride.cpp
===
alexfh requested changes to this revision.
This revision now requires changes to proceed.
Comment at: test/clang-rename/FunctionOverride.cpp:3
@@ +2,3 @@
+
+class A { virtual void foo(); };// CHECK: class A { virtual void boo(); };
+class B : public A { void foo(); }; // CHECK
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
1. Renaming overridden functions only works for two levels of "overriding
hierarchy". `clang-rename` should recursively add overridden methods.
2. Make use of `forEachOverridden` AST M
