[PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

2020-10-19 Thread Vedant Kumar via Phabricator via cfe-commits
vsk abandoned this revision. vsk added a comment. This isn't on my radar at the moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22943/new/ https://reviews.llvm.org/D22943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

2020-10-19 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Herald added subscribers: pengfei, fedor.sergeev, kristof.beyls, krytarowski. Herald added a reviewer: JDevlieghere. I'm not sure if you're still interested in pursuing this, b

Re: [PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

2016-08-04 Thread Joerg Sonnenberger via cfe-commits
On Mon, Aug 01, 2016 at 08:50:59AM -0700, Vedant Kumar wrote: > > > On Jul 30, 2016, at 12:59 PM, Joerg Sonnenberger via cfe-commits > > wrote: > > > > On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote: > >> - test/Driver/netbsd.c > >> > >>We see -mcpu=arm1022e instead of arm92

Re: [PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

2016-08-03 Thread Eric Christopher via cfe-commits
echristo added a comment. Seems reasonable to fix the tests? https://reviews.llvm.org/D22943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

2016-08-01 Thread Vedant Kumar via cfe-commits
> On Jul 30, 2016, at 12:59 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote: >> - test/Driver/netbsd.c >> >>We see -mcpu=arm1022e instead of arm926ej-s in a single run. > > Which one exactly? Here is the test (test/Driver/

Re: [PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

2016-07-30 Thread Joerg Sonnenberger via cfe-commits
On Thu, Jul 28, 2016 at 10:11:05PM +, Vedant Kumar wrote: > - test/Driver/netbsd.c > > We see -mcpu=arm1022e instead of arm926ej-s in a single run. Which one exactly? Joerg ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D22943: [Driver] Add FIXME's where we can't use effective triples (NFC)

2016-07-28 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added reviewers: echristo, dexonsmith. vsk added subscribers: joerg, rengolin, cfe-commits. Herald added subscribers: mehdi_amini, aemerson. ... even though we *should* be able to. If we used effective triples at the marked sites, we would fail: - test/Driver/{da