This revision was automatically updated to reflect the committed changes.
Closed by commit rL276870: change Vim key binding for include-fixer and
clang-rename (authored by omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D22854?vs=65739&id=65741#toc
Repository:
rL LLVM
https://re
omtcyfz added inline comments.
Comment at: docs/clang-rename.rst:101
@@ +100,3 @@
+[``
key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
+is a reference to a specific key defined by the mapleader variable and is
binded
+to backslash by default.
alexfh added inline comments.
Comment at: docs/include-fixer.rst:73
@@ +72,3 @@
+[``
key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
+is a reference to a specific key defined by the mapleader variable and is
binded
+to backslash by default.
-
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: docs/clang-rename.rst:101
@@ +100,3 @@
+[``
key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
+is a reference to a specifi
omtcyfz updated this revision to Diff 65739.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D22854
Files:
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
docs/include-fixer.rst
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-f
omtcyfz added inline comments.
Comment at: docs/clang-rename.rst:101
@@ +100,3 @@
+[``
key``](http://vim.wikia.com/wiki/Mapping_keys_in_Vim_-_Tutorial_(Part_3)#Map_leader)
+is a reference to a specific key defined by the mapleader variable and is
binded
+to backslash by default.
ioeric added inline comments.
Comment at: docs/clang-rename.rst:98
@@ +97,3 @@
+
+Once installed, you can point your cursor to the symbols you want to rename,
+press ``cr`` and print new desired name. The
s/the symbols/symbols/
Comment at: docs/c
omtcyfz added a comment.
Any other comments?
https://reviews.llvm.org/D22854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added a comment.
In https://reviews.llvm.org/D22854#497496, @vmiklos wrote:
> `:help leader` explains it. Or see this link:
> http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The
> later describes 3 arguments for using `` instead of `,` directly.
I think the poin
omtcyfz updated this revision to Diff 65714.
omtcyfz added a comment.
add refernce to what `` is
https://reviews.llvm.org/D22854
Files:
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
docs/include-fixer.rst
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/cla
vmiklos added a subscriber: vmiklos.
vmiklos added a comment.
`:help leader` explains it. Or see this link:
http://learnvimscriptthehardway.stevelosh.com/chapters/06.html#leader. The
later describes 3 arguments for using `` instead of `,` directly.
https://reviews.llvm.org/D22854
__
ioeric added a comment.
Could you briefly explain what is and how to lookup/set it in the doc,
or at least provide reference?
https://reviews.llvm.org/D22854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek, ioeric.
omtcyfz added a subscriber: cfe-commits.
Change Vim key binding for include-fixer (`,cf` -> `cf`) and
clang-rename (`,cr` -> `cr`) to use `` instead of `,` like cool
Vim people (tm) do.
https://reviews.llvm.org/D228
13 matches
Mail list logo
