Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

2016-07-25 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276726: [OpenMP] diagnose orphaned teams construct (authored by kli). Changed prior to commit: https://reviews.llvm.org/D22785?vs=65430&id=65472#toc Repository: rL LLVM https://reviews.llvm.org/D227

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

2016-07-25 Thread Kelvin Li via cfe-commits
kkwli0 added a comment. Will add the braces. Thanks. https://reviews.llvm.org/D22785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22785: [OpenMP] diagnose orphaned teams construct

2016-07-25 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: lib/Sema/SemaOpenMP.cpp:3360-3366 @@ -3356,5 +3359,9 @@ if (NestingProhibited) { - SemaRef.Diag(StartLoc, diag::err_omp_prohibited_region

[PATCH] D22785: [OpenMP] diagnose orphaned teams construct

2016-07-25 Thread Kelvin Li via cfe-commits
kkwli0 created this revision. kkwli0 added reviewers: ABataev, sfantao, carlo.bertolli, arpith-jacob, hfinkel. kkwli0 added a subscriber: cfe-commits. The spec mandates that 'a teams construct must be contained within a target construct'. Currently, this scenario is not diagnosed. This patch is