On Wed, Sep 7, 2016 at 7:14 PM, Richard Smith wrote:
> On 7 Sep 2016 6:59 pm, "Peter Collingbourne" wrote:
>
> On Wed, Sep 7, 2016 at 6:44 PM, Richard Smith
> wrote:
>
>> On 7 Sep 2016 6:23 pm, "Peter Collingbourne" wrote:
>>
>> pcc marked 4 inline comments as done.
>>
>>
>> C
On 7 Sep 2016 6:59 pm, "Peter Collingbourne" wrote:
On Wed, Sep 7, 2016 at 6:44 PM, Richard Smith wrote:
> On 7 Sep 2016 6:23 pm, "Peter Collingbourne" wrote:
>
> pcc marked 4 inline comments as done.
>
>
> Comment at: lib/CodeGen/CGVTables.cpp:588
> @@ +587,3 @@
> +if
On Wed, Sep 7, 2016 at 6:44 PM, Richard Smith wrote:
> On 7 Sep 2016 6:23 pm, "Peter Collingbourne" wrote:
>
> pcc marked 4 inline comments as done.
>
>
> Comment at: lib/CodeGen/CGVTables.cpp:588
> @@ +587,3 @@
> +if (auto *F = dyn_cast(Cache))
> + F->setUnname
On 7 Sep 2016 6:23 pm, "Peter Collingbourne" wrote:
pcc marked 4 inline comments as done.
Comment at: lib/CodeGen/CGVTables.cpp:588
@@ +587,3 @@
+if (auto *F = dyn_cast(Cache))
+ F->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
+Cache = llvm::C
pcc marked 4 inline comments as done.
Comment at: lib/CodeGen/CGVTables.cpp:588
@@ +587,3 @@
+if (auto *F = dyn_cast(Cache))
+ F->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::Global);
+Cache = llvm::ConstantExpr::getBitCast(Cache, CGM.Int8PtrTy);
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280897: CodeGen: Clean up implementation of vtable
initializer builder. NFC. (authored by pcc).
Changed prior to commit:
https://reviews.llvm.org/D22642?vs=70622&id=70632#toc
Repository:
rL LLVM
htt
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: include/clang/AST/VTableBuilder.h:222-225
@@ -221,6 +221,6 @@
typedef const VTableComponent *vtable_component_iterator;
typedef const VTableThunkTy *vtable_thunk_iterator;
typede
pcc updated this revision to Diff 70622.
pcc added a comment.
- Refresh
https://reviews.llvm.org/D22642
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CGVTables.h
lib/CodeGen/ItaniumCXXABI.cpp
lib/CodeGen/MicrosoftCXXABI.cp
pcc created this revision.
pcc added a reviewer: rsmith.
pcc added a subscriber: cfe-commits.
- Simplify signature of CreateVTableInitializer function.
- Move vtable component builder to a separate function.
- Remove unnecessary accessors from VTableLayout class.
This is in preparation for a futu
