This revision was automatically updated to reflect the committed changes.
Closed by commit rL277181: [OpenCL] Add extension cl_khr_mipmap_image to clang
(authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D22637?vs=65773&id=66150#toc
Repository:
rL LLVM
https://reviews.l
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D22637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ashi1 updated this revision to Diff 65773.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Removed indentation as per Anastasia's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Basic/Targets.cpp
test/Misc
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+ #endif
+#else
+ #ifdef cl_khr_mipmap_image
Looks good! Could you just remove indentation please as it's not common for C
macros?
The same for the test below!
ashi1 updated this revision to Diff 65582.
ashi1 added a comment.
Revised based on Anastasia's comments. Restructured the if statements in test
cases.
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Basic/Targets.cpp
test/Misc/am
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:228
@@ +227,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
Anastasia wrote:
> ashi1 wrote:
> > Anastasia wrote:
> > > C
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
ashi1 wrote:
> yaxunl wrote:
> > Anastasia wrote:
> > > Ca
ashi1 added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
yaxunl wrote:
> Anastasia wrote:
> > Can you move this error m
yaxunl added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
Anastasia wrote:
> Can you move this error message down inste
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
Can you move this error message down instead of adding 6 l
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D22637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
ashi1 updated this revision to Diff 65126.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Revised based on Sam's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Basic/Targets.cpp
test/Misc/amdgcn.language
yaxunl added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:190
@@ +189,3 @@
+// expected-warning@-1{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#endif
+
we also need to check the else case for `__OPENCL_C_VERSION__ < 20
ashi1 updated this revision to Diff 65118.
ashi1 marked an inline comment as done.
ashi1 added a comment.
Revised based on Sam's comments. Added to tests
Misc\amdgcn.languageOptsOpenCL.cl and SemaOpenCL\extension-version.cl
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
includ
yaxunl added inline comments.
Comment at: include/clang/Basic/OpenCLExtensions.def:73
@@ -72,2 +72,3 @@
OPENCLEXT_INTERNAL(cl_khr_terminate_context, 200, ~0U)
+OPENCLEXT_INTERNAL(cl_khr_mipmap_image, 200, ~0U)
Better to follow the alphabetical order.
Reposito
yaxunl added a comment.
Need to add a test to Misc/amdgcn.languageOptsOpenCL.cl and
SemaOpenCL/extension-version.cl
Repository:
rL LLVM
https://reviews.llvm.org/D22637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
ashi1 created this revision.
ashi1 added reviewers: yaxunl, Anastasia.
ashi1 added a subscriber: cfe-commits.
ashi1 set the repository for this revision to rL LLVM.
Adding extension cl_khr_mipmap_image to clang's OpenCL Extensions and initiated
inside AMDGPU Target.
Repository:
rL LLVM
https:
17 matches
Mail list logo
